From 47fe3f430dc206cc6f047c281a08001dba808918 Mon Sep 17 00:00:00 2001
From: an-lee <an.lee.work@gmail.com>
Date: Fri, 17 May 2024 10:48:47 +0800
Subject: [PATCH] Fix unhandled errors (#617)

* fix undefined

* prevent story preview unless url provided

* refactor
---
 enjoy/src/renderer/components/audios/audio-player.tsx         | 2 +-
 .../renderer/components/medias/media-current-recording.tsx    | 2 +-
 enjoy/src/renderer/components/misc/wavesurfer-player.tsx      | 2 ++
 enjoy/src/renderer/components/stories/story-form.tsx          | 1 +
 enjoy/src/renderer/context/media-player-provider.tsx          | 4 ++--
 5 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/enjoy/src/renderer/components/audios/audio-player.tsx b/enjoy/src/renderer/components/audios/audio-player.tsx
index eaa6d475..dd43a773 100644
--- a/enjoy/src/renderer/components/audios/audio-player.tsx
+++ b/enjoy/src/renderer/components/audios/audio-player.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useContext, useState } from "react";
+import { useEffect, useContext } from "react";
 import { MediaPlayerProviderContext } from "@renderer/context";
 import {
   MediaLoadingModal,
diff --git a/enjoy/src/renderer/components/medias/media-current-recording.tsx b/enjoy/src/renderer/components/medias/media-current-recording.tsx
index c9de688b..1eb49a94 100644
--- a/enjoy/src/renderer/components/medias/media-current-recording.tsx
+++ b/enjoy/src/renderer/components/medias/media-current-recording.tsx
@@ -417,7 +417,7 @@ export const MediaCurrentRecording = () => {
 
   useHotkeys(
     currentHotkeys.PlayOrPauseRecording,
-    (keyboardEvent, hotkeyEvent) => {
+    (keyboardEvent, _hotkeyEvent) => {
       if (!player) return;
       keyboardEvent.preventDefault();
 
diff --git a/enjoy/src/renderer/components/misc/wavesurfer-player.tsx b/enjoy/src/renderer/components/misc/wavesurfer-player.tsx
index 3439a7a5..b9387511 100644
--- a/enjoy/src/renderer/components/misc/wavesurfer-player.tsx
+++ b/enjoy/src/renderer/components/misc/wavesurfer-player.tsx
@@ -25,6 +25,8 @@ export const WavesurferPlayer = (props: {
   const [duration, setDuration] = useState<number>(0);
 
   const onPlayClick = useCallback(() => {
+    if (!wavesurfer) return;
+
     wavesurfer.isPlaying() ? wavesurfer.pause() : wavesurfer.play();
   }, [wavesurfer]);
 
diff --git a/enjoy/src/renderer/components/stories/story-form.tsx b/enjoy/src/renderer/components/stories/story-form.tsx
index df0397f2..d862aba2 100644
--- a/enjoy/src/renderer/components/stories/story-form.tsx
+++ b/enjoy/src/renderer/components/stories/story-form.tsx
@@ -17,6 +17,7 @@ export const StoryForm = () => {
           placeholder={t("inputUrlToStartReading")}
         />
         <Button
+          disabled={!url}
           onClick={() =>
             navigate(`/stories/preview/${encodeURIComponent(url)}`)
           }
diff --git a/enjoy/src/renderer/context/media-player-provider.tsx b/enjoy/src/renderer/context/media-player-provider.tsx
index fbbbe8fe..0679cefd 100644
--- a/enjoy/src/renderer/context/media-player-provider.tsx
+++ b/enjoy/src/renderer/context/media-player-provider.tsx
@@ -443,8 +443,8 @@ export const MediaPlayerProvider = ({
         setDecoded(true);
       }),
       wavesurfer.on("error", (err: Error) => {
-        toast.error(err.message);
-        setDecodeError(err.message);
+        toast.error(err?.message || "Error occurred while decoding audio");
+        setDecodeError(err?.message || "Error occurred while decoding audio");
       }),
     ];