lostecho/grokking_algorithms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update 04_recursive_max.js with fix for alternative solution (#262)

Browse Source 
* Update 04_recursive_max.js with fix for alternative solution

Current alternative solution works only for arrays of natural numbers and for empty arrays it returns 0 instead of null or Error. This commit fixes these problems.

* Considering comments from the author

---------

Co-authored-by: Ilia Poliakov <ilia.poliakov@macys.com>
This commit is contained in:
Poliakov Ilia
2024-12-07 17:44:23 +04:00
committed by GitHub
parent 440db4ff11
commit 00b28478ce
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
04_quicksort/javascript/04_recursive_max.js
View File

@@ -14,12 +14,12 @@ function max(array) {
/** /**
* Calculate the largest number * Calculate the largest number
* This solution works for arrays of any length * This solution works for arrays of any length and returns the smallest possible number for empty arrays
* @param {Array} array Array of numbers * @param {Array} array Array of numbers
* @param {number} max Maximum value * @param {number} max Maximum value
* @returns {number} The argest number * @returns {number} The largest number
*/ */
function alternativeSolutionMax(array, max = 0) { function alternativeSolutionMax(array, max = Number.MIN_VALUE) {
return array.length === 0 return array.length === 0
? max ? max
: alternativeSolutionMax(array.slice(1), array[0] > max ? array[0] : max); : alternativeSolutionMax(array.slice(1), array[0] > max ? array[0] : max);
@@ -27,3 +27,6 @@ function alternativeSolutionMax(array, max = 0) {
console.log(max([1, 5, 10, 25, 16, 1])); // 25 console.log(max([1, 5, 10, 25, 16, 1])); // 25
console.log(alternativeSolutionMax([1, 5, 10, 25, 16, 1])); // 25 console.log(alternativeSolutionMax([1, 5, 10, 25, 16, 1])); // 25
console.log(max([])); // RangeError: Maximum call stack size exceeded
console.log(alternativeSolutionMax([])); // Number.MIN_VALUE