lostecho/Pake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 Fix formatting and testing code

Browse Source
This commit is contained in:
Tw93
2025-08-21 21:14:42 +08:00
parent a539067e57
commit 9fa4b9daad
4 changed files with 116 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
package.json
View File

@@ -39,8 +39,8 @@
"tauri": "tauri",
"cli": "cross-env NODE_ENV=development rollup -c -w",
"cli:build": "cross-env NODE_ENV=production rollup -c",
"test": "npm run cli:build && PAKE_CREATE_APP=1 node tests/index.js",
"format": "prettier --write . --ignore-unknown && cd src-tauri && cargo fmt --verbose",
"test": "npm run cli:build && cross-env PAKE_CREATE_APP=1 node tests/index.js",
"format": "prettier --write . --ignore-unknown && find tests -name '*.js' -exec sed -i '' 's/[[:space:]]*$//' {} \\; && cd src-tauri && cargo fmt --verbose",
"prepublishOnly": "npm run cli:build"
},
"type": "module",

6
src-tauri/src/app/window.rs
View File

@@ -28,11 +28,7 @@ pub fn set_window(app: &mut App, config: &PakeConfig, tauri_config: &Config) ->
serde_json::to_string(&window_config).unwrap()
);
let window_title = window_config
.title
.as_ref()
.map(|t| t.as_str())
.unwrap_or("");
let window_title = window_config.title.as_deref().unwrap_or("");
let mut window_builder = WebviewWindowBuilder::new(app, "pake", url)
.title(window_title)

66
tests/github.js
View File

@@ -254,7 +254,7 @@ console.log('URL:', process.env.URL);
console.log('NAME:', process.env.NAME);
// Test that environment variables are properly passed
const success = process.env.URL === 'https://github.com' &&
const success = process.env.URL === 'https://github.com' &&
process.env.NAME === 'github' &&
process.env.HEIGHT === '780' &&
process.env.WIDTH === '1200';
@@ -461,22 +461,22 @@ runner.addTest(
const generateMacBuildCommand = (multiArch, debug, features = ['cli-build']) => {
if (!multiArch) {
const baseCommand = debug ? 'npm run tauri build -- --debug' : 'npm run tauri build --';
return features.length > 0 ?
\`\${baseCommand} --features \${features.join(',')}\` :
return features.length > 0 ?
\`\${baseCommand} --features \${features.join(',')}\` :
baseCommand;
}
const baseCommand = debug
? 'npm run tauri build -- --debug'
: 'npm run tauri build --';
const configPath = 'src-tauri/.pake/tauri.conf.json';
let fullCommand = \`\${baseCommand} --target universal-apple-darwin -c "\${configPath}"\`;
if (features.length > 0) {
fullCommand += \` --features \${features.join(',')}\`;
}
return fullCommand;
};
@@ -576,12 +576,12 @@ runner.addTest(
// Test Rust feature flag logic
const validateFeatureFlags = (platform, darwinVersion = 23) => {
const features = ['cli-build'];
// Add macos-proxy feature for modern macOS (Darwin 23+ = macOS 14+)
if (platform === 'darwin' && darwinVersion >= 23) {
features.push('macos-proxy');
features.push('macos-proxy');
}
return features;
};
@@ -633,52 +633,52 @@ runner.addTest(
const validateConfig = (config) => {
const required = ['url', 'name', 'width', 'height'];
const optional = ['icon', 'fullscreen', 'debug', 'multiArch'];
// Check required fields
const hasRequired = required.every(field => config.hasOwnProperty(field));
// Check field types
const validTypes =
const validTypes =
typeof config.url === 'string' &&
typeof config.name === 'string' &&
typeof config.width === 'number' &&
typeof config.height === 'number';
// Check URL format
let validUrl = false;
try {
new URL(config.url);
validUrl = true;
} catch {}
// Check name is not empty
const validName = config.name.length > 0;
return hasRequired && validTypes && validUrl && validName;
};
// Test different configurations
const configs = [
{
url: 'https://github.com',
name: 'github',
width: 1200,
{
url: 'https://github.com',
name: 'github',
width: 1200,
height: 780,
valid: true
valid: true
},
{
url: 'invalid-url',
name: 'test',
width: 800,
{
url: 'invalid-url',
name: 'test',
width: 800,
height: 600,
valid: false
valid: false
},
{
url: 'https://example.com',
name: '',
width: 1000,
{
url: 'https://example.com',
name: '',
width: 1000,
height: 700,
valid: false
valid: false
},
];
@@ -755,7 +755,7 @@ const command = 'pake ' + process.env.URL + ' --name ' + process.env.NAME + ' --
console.log('Build command:', command);
// Simulate build process validation
const validBuild =
const validBuild =
process.env.URL === 'https://github.com' &&
process.env.NAME === 'github' &&
process.env.WIDTH === '1200' &&
@@ -825,7 +825,7 @@ const env = {
};
// Test parameter validation
const validParams =
const validParams =
env.URL === 'https://github.com' &&
env.NAME === 'github' &&
env.WIDTH === '1200' &&

112
tests/index.js
View File

@@ -610,11 +610,64 @@ class PakeTestRunner {
async () => {
return new Promise((resolve, reject) => {
const testName = "GitHubRealBuild";
const appFile = path.join(config.PROJECT_ROOT, `${testName}.app`);
const dmgFile = path.join(config.PROJECT_ROOT, `${testName}.dmg`);
// Platform-specific output files
const outputFiles = {
darwin: {
app: path.join(config.PROJECT_ROOT, `${testName}.app`),
installer: path.join(config.PROJECT_ROOT, `${testName}.dmg`),
},
linux: {
app: path.join(
config.PROJECT_ROOT,
`src-tauri/target/release/bundle/deb/${testName.toLowerCase()}_*.deb`,
),
installer: path.join(
config.PROJECT_ROOT,
`src-tauri/target/release/bundle/appimage/${testName.toLowerCase()}_*.AppImage`,
),
},
win32: {
app: path.join(config.PROJECT_ROOT, `${testName}.exe`),
installer: path.join(config.PROJECT_ROOT, `${testName}.msi`),
},
};
const platform = process.platform;
const expectedFiles = outputFiles[platform] || outputFiles.darwin;
// Helper function to check if files exist (handles wildcards for Linux)
const checkFileExists = (filePath) => {
if (filePath.includes("*")) {
const dir = path.dirname(filePath);
const pattern = path.basename(filePath);
try {
const files = fs.readdirSync(dir);
const regex = new RegExp(pattern.replace(/\*/g, ".*"));
return files.some((file) => regex.test(file));
} catch {
return false;
}
}
return fs.existsSync(filePath);
};
const getActualFilePath = (filePath) => {
if (filePath.includes("*")) {
const dir = path.dirname(filePath);
const pattern = path.basename(filePath);
try {
const files = fs.readdirSync(dir);
const regex = new RegExp(pattern.replace(/\*/g, ".*"));
const match = files.find((file) => regex.test(file));
return match ? path.join(dir, match) : filePath;
} catch {
return filePath;
}
}
return filePath;
};
console.log(`🔧 Starting real build test for GitHub.com...`);
console.log(`📝 Expected output: ${appFile}`);
console.log(`📝 Expected output: ${expectedFiles.app}`);
const command = `node "${config.CLI_PATH}" "https://github.com" --name "${testName}" --width 1200 --height 800 --hide-title-bar`;
@@ -630,8 +683,6 @@ class PakeTestRunner {
let buildStarted = false;
let compilationStarted = false;
let bundlingStarted = false;
let buildCompleted = false;
// Track progress without too much noise
child.stdout.on("data", (data) => {
@@ -648,11 +699,9 @@ class PakeTestRunner {
console.log(" ⚙️ Compiling...");
}
if (output.includes("Bundling")) {
bundlingStarted = true;
console.log(" 📦 Bundling...");
}
if (output.includes("Built application at:")) {
buildCompleted = true;
console.log(" ✅ Build completed!");
}
});
@@ -661,31 +710,35 @@ class PakeTestRunner {
const output = data.toString();
if (output.includes("Building app")) buildStarted = true;
if (output.includes("Compiling")) compilationStarted = true;
if (output.includes("Bundling")) bundlingStarted = true;
if (output.includes("Finished"))
console.log(" ✅ Compilation finished!");
if (output.includes("Built application at:")) buildCompleted = true;
});
// Real timeout - 8 minutes for actual build
const timeout = setTimeout(() => {
const appExists = fs.existsSync(appFile);
const dmgExists = fs.existsSync(dmgFile);
const appExists = checkFileExists(expectedFiles.app);
const installerExists = checkFileExists(expectedFiles.installer);
if (appExists) {
console.log(
" 🎉 Build completed successfully (app file exists)!",
);
console.log(` 📱 App location: ${appFile}`);
if (dmgExists) {
console.log(` 💿 DMG location: ${dmgFile}`);
console.log(
` 📱 App location: ${getActualFilePath(expectedFiles.app)}`,
);
if (installerExists) {
console.log(
` 💿 Installer location: ${getActualFilePath(expectedFiles.installer)}`,
);
}
console.log(" ✨ Build artifacts preserved for inspection");
child.kill("SIGTERM");
resolve(true);
} else {
console.log(" ❌ Build timeout - no app file generated");
console.log(` 📍 Expected location: ${appFile}`);
console.log(
" ⚠️ Build process completed but no app file found",
);
console.log(` 📍 Expected location: ${expectedFiles.app}`);
child.kill("SIGTERM");
reject(new Error("Real build test timeout"));
}
@@ -694,18 +747,18 @@ class PakeTestRunner {
child.on("close", (code) => {
clearTimeout(timeout);
const appExists = fs.existsSync(appFile);
const dmgExists = fs.existsSync(dmgFile);
// DON'T track files for cleanup - let user see the results
// this.trackTempFile(appFile);
// this.trackTempFile(dmgFile);
const appExists = checkFileExists(expectedFiles.app);
const installerExists = checkFileExists(expectedFiles.installer);
const actualAppPath = getActualFilePath(expectedFiles.app);
const actualInstallerPath = getActualFilePath(
expectedFiles.installer,
);
if (appExists) {
console.log(" 🎉 Real build test SUCCESS: App file generated!");
console.log(` 📱 App location: ${appFile}`);
if (dmgExists) {
console.log(` 💿 DMG location: ${dmgFile}`);
console.log(` 📱 App location: ${actualAppPath}`);
if (installerExists) {
console.log(` 💿 Installer location: ${actualInstallerPath}`);
}
console.log(" ✨ Build artifacts preserved for inspection");
resolve(true);
@@ -713,7 +766,7 @@ class PakeTestRunner {
console.log(
" ⚠️ Build process completed but no app file found",
);
console.log(` 📍 Expected location: ${appFile}`);
console.log(` 📍 Expected location: ${expectedFiles.app}`);
resolve(false);
} else {
reject(new Error(`Real build test failed with code ${code}`));
@@ -762,9 +815,6 @@ class PakeTestRunner {
let buildStarted = false;
let compilationStarted = false;
let bundlingStarted = false;
let buildCompleted = false;
let multiArchDetected = false;
// Track progress
child.stdout.on("data", (data) => {
@@ -784,11 +834,9 @@ class PakeTestRunner {
output.includes("universal-apple-darwin") ||
output.includes("Universal")
) {
multiArchDetected = true;
console.log(" 🔀 Universal binary target detected");
}
if (output.includes("Bundling")) {
bundlingStarted = true;
console.log(" 📦 Bundling universal binary...");
}
if (output.includes("Built application at:")) {
@@ -1029,7 +1077,7 @@ Usage: node tests/index.js [options]
Options:
--unit Run unit tests (default)
--integration Run integration tests (default)
--integration Run integration tests (default)
--builder Run builder tests (default)
--pake-cli Run pake-cli GitHub Actions tests
--e2e, --full Run end-to-end tests