Merge pull request #85 from Fandroid745/fix/screenwakeup

feat:Fix issue where screen does not wake up when the timer ends
This commit is contained in:
Nishant Mishra
2025-10-22 11:51:55 +05:30
committed by GitHub
4 changed files with 47 additions and 3 deletions

View File

@@ -7,6 +7,7 @@
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
<uses-permission android:name="android.permission.POST_PROMOTED_NOTIFICATIONS" />
<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="android.permission.WAKE_LOCK" />
<application
android:name=".TomatoApplication"

View File

@@ -20,7 +20,7 @@ import org.nsh07.pomodoro.utils.toColor
class MainActivity : ComponentActivity() {
private val timerViewModel: TimerViewModel by viewModels(factoryProducer = { TimerViewModel.Factory })
private val timerViewModel: TimerViewModel by viewModels(factoryProducer = { TimerViewModel.Factory })
private val settingsViewModel: SettingsViewModel by viewModels(factoryProducer = { SettingsViewModel.Factory })
private val appContainer by lazy {
@@ -59,6 +59,7 @@ class MainActivity : ComponentActivity() {
}
}
override fun onStop() {
super.onStop()
// Reduce the timer loop frequency when not visible to save battery power

View File

@@ -7,6 +7,7 @@ import android.media.AudioAttributes
import android.media.MediaPlayer
import android.os.Build
import android.os.IBinder
import android.os.PowerManager
import android.os.SystemClock
import android.os.VibrationEffect
import android.os.Vibrator
@@ -22,6 +23,7 @@ import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking
import org.nsh07.pomodoro.MainActivity
import org.nsh07.pomodoro.R
import org.nsh07.pomodoro.TomatoApplication
import org.nsh07.pomodoro.ui.timerScreen.viewModel.TimerMode
@@ -59,6 +61,9 @@ class TimerService : Service() {
private var alarm: MediaPlayer? = null
private var wakeLock: PowerManager.WakeLock? = null
private val vibrator by lazy {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
val vibratorManager = getSystemService(VIBRATOR_MANAGER_SERVICE) as VibratorManager
@@ -89,6 +94,7 @@ class TimerService : Service() {
saveTimeToDb()
notificationManager.cancel(1)
alarm?.release()
wakeLock?.release()
}
super.onDestroy()
}
@@ -117,6 +123,7 @@ class TimerService : Service() {
return super.onStartCommand(intent, flags, startId)
}
private fun toggleTimer() {
updateProgressSegments()
@@ -157,6 +164,20 @@ class TimerService : Service() {
if (iterations == 0) showTimerNotification(time.toInt())
if (time < 0) {
val powerManager = this@TimerService.getSystemService(POWER_SERVICE) as PowerManager
wakeLock = powerManager.newWakeLock(
PowerManager.SCREEN_BRIGHT_WAKE_LOCK or
PowerManager.ACQUIRE_CAUSES_WAKEUP or
PowerManager.ON_AFTER_RELEASE,
"PomodoroApp:AlarmWakeLock"
)
wakeLock?.acquire(2 * 60 * 1000L)
val intent = Intent(this@TimerService, MainActivity::class.java).apply {
addFlags(Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_SINGLE_TOP)
}
startActivity(intent)
skipTimer()
_timerState.update { currentState ->
currentState.copy(timerRunning = false)
@@ -176,7 +197,7 @@ class TimerService : Service() {
}
}
@SuppressLint("MissingPermission") // We check for the permission when pressing the Play button in the UI
@SuppressLint("MissingPermission", "StringFormatInvalid") // We check for the permission when pressing the Play button in the UI
fun showTimerNotification(
remainingTime: Int, paused: Boolean = false, complete: Boolean = false
) {
@@ -372,6 +393,9 @@ class TimerService : Service() {
vibrator.cancel()
}
wakeLock?.release()
wakeLock = null
_timerState.update { currentState ->
currentState.copy(alarmRinging = false)
}

View File

@@ -7,6 +7,7 @@
package org.nsh07.pomodoro.ui.timerScreen
import androidx.activity.compose.LocalActivity
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
@@ -24,6 +25,7 @@ import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
@@ -37,6 +39,21 @@ fun AlarmDialog(
modifier: Modifier = Modifier,
stopAlarm: () -> Unit
) {
val activity = LocalActivity.current
// Set lockscreen flags when dialog appears, remove when it disappears
DisposableEffect(Unit) {
// Show over lockscreen
activity?.setShowWhenLocked(true)
activity?.setTurnScreenOn(true)
onDispose {
// Remove lockscreen flags when dialog is dismissed
activity?.setShowWhenLocked(false)
activity?.setTurnScreenOn(false)
}
}
BasicAlertDialog(
onDismissRequest = stopAlarm,
modifier = modifier
@@ -75,4 +92,5 @@ fun AlarmDialog(
}
}
}
}
}