lostecho/ncspot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: fetch album only once

Browse Source 
Should speed up display of the context menu

Fixes #1225
This commit is contained in:
Henrik Friedrichsen
2023-07-23 14:46:29 +02:00
parent bef4742cec
commit 0c13afb46f
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/ui/contextmenu.rs
View File

@@ -200,6 +200,7 @@ impl ContextMenu {
pub fn new(item: &dyn ListItem, queue: Arc<Queue>, library: Arc<Library>) -> NamedView<Self> {
let mut content: SelectView<ContextMenuAction> = SelectView::new();
let album = item.album(&queue);
if item.is_playable() {
if item.is_playing(&queue)
@@ -238,8 +239,11 @@ impl ContextMenu {
}
}
if let Some(a) = item.album(&queue) {
content.add_item("Show album", ContextMenuAction::ShowItem(Box::new(a)));
if let Some(ref a) = album {
content.add_item(
"Show album",
ContextMenuAction::ShowItem(Box::new(a.clone())),
);
}
#[cfg(feature = "share_clipboard")]
@@ -247,7 +251,7 @@ impl ContextMenu {
if let Some(url) = item.share_url() {
content.add_item("Share", ContextMenuAction::ShareUrl(url));
}
if let Some(url) = item.album(&queue).and_then(|a| a.share_url()) {
if let Some(url) = album.as_ref().and_then(|a| a.share_url()) {
content.add_item("Share album", ContextMenuAction::ShareUrl(url));
}
}
@@ -273,14 +277,14 @@ impl ContextMenu {
);
}
if let Some(album) = item.album(&queue) {
if let Some(savestatus) = album.is_saved(&library) {
if let Some(ref a) = album {
if let Some(savestatus) = a.is_saved(&library) {
content.add_item(
match savestatus {
true => "Unsave album",
false => "Save album",
},
ContextMenuAction::ToggleSavedStatus(album.as_listitem()),
ContextMenuAction::ToggleSavedStatus(a.as_listitem()),
);
}
}