lostecho/ncspot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: remove unused screenchange variable

Browse Source 
The `screenchange` member variable on `Layout` didn't seem to be used
for anything except for debugging. A comment in `on_layout` makes it
seem like it wasn't meant to be used for debugging purposes but for
actual functionality that wasn't implemented.
This commit is contained in:
Thomas Frans
2023-06-18 16:41:47 +02:00
committed by Henrik Friedrichsen
parent d644397180
commit 0c93cafccf
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/ui/layout.rs
View File

@@ -11,7 +11,6 @@ use cursive::vec::Vec2;
use cursive::view::{CannotFocus, IntoBoxedView, Selector}; use cursive::view::{CannotFocus, IntoBoxedView, Selector};
use cursive::views::EditView; use cursive::views::EditView;
use cursive::{Cursive, Printer}; use cursive::{Cursive, Printer};
use log::debug;
use unicode_width::UnicodeWidthStr; use unicode_width::UnicodeWidthStr;
use crate::application::UserData; use crate::application::UserData;
@@ -31,7 +30,6 @@ pub struct Layout {
cmdline_focus: bool, cmdline_focus: bool,
result: Result<Option<String>, String>, result: Result<Option<String>, String>,
result_time: Option<SystemTime>, result_time: Option<SystemTime>,
screenchange: bool,
last_size: Vec2, last_size: Vec2,
ev: events::EventManager, ev: events::EventManager,
theme: Theme, theme: Theme,
@@ -100,7 +98,6 @@ impl Layout {
cmdline_focus: false, cmdline_focus: false,
result: Ok(None), result: Ok(None),
result_time: None, result_time: None,
screenchange: true,
last_size: Vec2::new(0, 0), last_size: Vec2::new(0, 0),
ev: ev.clone(), ev: ev.clone(),
theme, theme,
@@ -150,7 +147,6 @@ impl Layout {
let s = id.into(); let s = id.into();
self.focus = Some(s); self.focus = Some(s);
self.cmdline_focus = false; self.cmdline_focus = false;
self.screenchange = true;
// trigger a redraw // trigger a redraw
self.ev.trigger(); self.ev.trigger();
@@ -343,13 +339,6 @@ impl View for Layout {
if let Some(view) = self.get_current_view_mut() { if let Some(view) = self.get_current_view_mut() {
view.layout(Vec2::new(size.x, size.y - 3)); view.layout(Vec2::new(size.x, size.y - 3));
} }
// the focus view has changed, let the views know so they can redraw
// their items
if self.screenchange {
debug!("layout: new screen selected: {:?}", self.focus);
self.screenchange = false;
}
} }
fn required_size(&mut self, constraint: Vec2) -> Vec2 { fn required_size(&mut self, constraint: Vec2) -> Vec2 {